-
Notifications
You must be signed in to change notification settings - Fork 27.4k
test(ngMock): fix Firefox crashes on Travis #16040
Conversation
0900ad0
to
0ee62f8
Compare
804b9b9
to
3c66f28
Compare
This test keeps causing Firefox 47 (currently used on Travis) to crash and fail the build. The test passes locally (on Firefox 53). Lowering the loop count from 1000 to 100 seems to fix the issue. (Note: The crach only affects the mocked implementation of `$interval` and does not happen locally.)
20e3cec
to
4a06791
Compare
If I remember correctly, browsers can't actually guarantee an interval of 1ms. Maybe we should instead set it to 10ms to relieve the pressure? Or do you think the condition in the test with 1000 loops is unrealistic and doesn't need to be tested? |
But this is a mock |
You are right, I read over the fact that this is only the mock implementation. But it looks like the "fake" interval of 1ms also causes the browsers in question problems - which could maybe be handled by using a slightly higher interval, which would also be more in line with what browsers do with real intervals. |
I haven't tried it but I suspect it is something about the loop count that throws Firefox off. Even if we increased the faked interval to 10ms, using |
Ok, in that case I'm fine with changing just the test |
OK. |
This test keeps causing Firefox 47 (currently used on Travis) to crash and fail the build. The test passes locally (on Firefox 53). Lowering the loop count from 1000 to 100 seems to fix the issue. (Note: The crach only affects the mocked implementation of `$interval` and does not happen locally.) Closes #16040
This test keeps causing Firefox 47 (currently used on Travis) to crash and fail the build. The test passes locally (on Firefox 53). Lowering the loop count from 1000 to 100 seems to fix the issue.
(Note: The crach only affects the mocked implementation of
$interval
and does not happen locally.)